From: Martin Ågren <martin.agren@gmail.com>
Date: Fri, 03 Apr 2020 05:21:58 GMT
Subject: Re: [PATCH v2 1/5] rebase.c: honour --no-gpg-sign
Message-ID: <CAN0heSob_O4hNj8-9eLc3Qq-Cj-SzWyOkdQh8zG0bqSFTvpwoA@mail.gmail.com>
In-Reply-To: <9975d4c61301f865dbd6aa3e1f70c6b5cc64daf0.1585821581.git.congdanhqx@gmail.com>

Hi Danh,

On Thu, 2 Apr 2020 at 12:17, Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:
>
>  -S[<keyid>]::
>  --gpg-sign[=<keyid>]::
> +--no-gpg-sign::
>         GPG-sign commits. The `keyid` argument is optional and
>         defaults to the committer identity; if specified, it must be
> -       stuck to the option without a space.
> +       stuck to the option without a space. "--no-gpg-sign" is useful to
> +       countermand both `commit.gpgSign` configuration variable, and
> +       earlier "--gpg-sign".

Please use `backticks`: `--no-gpg-sign` and `--gpg-sign` just like you
do with `commit.gpgSign`. It will then end up typeset in monospace. This
comment applies to all five patches.

Thanks for working on this.

Martin