From: Martin Ă…gren Date: Wed, 19 Dec 2018 21:43:21 GMT Subject: Re: [PATCH 2/3] setup: do not use invalid `repository_format` Message-ID: In-Reply-To: <20181219001801.GA520988@genre.crustytoothpaste.net> On Wed, 19 Dec 2018 at 01:18, brian m. carlson wrote: > I think this change is fine, because we initialize the value in > the_repository elsewhere, and if there's no repository, this should > never have a value other than the default anyway. Thanks, it feels good that this patch matches how you think about the `hash_algo` field. > I looked at the other patches in the series and thought they looked sane > as well. Thanks for a review, I appreciate it. Martin