From: Martin Ågren <martin.agren@gmail.com>
Date: Thu, 07 Jan 2021 18:17:23 GMT
Subject: Re: [PATCH 0/5] avoid peeking into `struct lock_file`
Message-ID: <CAN0heSoK21Qx_x-69KtmuScU6cN1SqB45ptgDwV8qpeh1iTC0Q@mail.gmail.com>
In-Reply-To: <xmqqft3dma54.fsf@gitster.c.googlers.com>

On Thu, 7 Jan 2021 at 09:19, Junio C Hamano <gitster@pobox.com> wrote:
>
> Martin Ågren <martin.agren@gmail.com> writes:
>
> > I could add a remark in the commit message of the last patch along the
> > lines of "After this commit, renaming the `tempfile` field only triggers
> > compilation errors in lockfile.[ch] and this one instance that we're
> > intentionally leaving here.".
>
> It would be a nice addition to the log message to help readers to
> feel confident about the conversion.  It is OK if you want to add
> one, and certainly a good trick to have in your toolbox for your
> next conversion, but it may not be worth rerolling only to update
> the log message with such a remark.

Ok, got it. So I'm not planning to reroll this series. Unless something
else shows up, obviously.

Thank you.

Martin