From: Felipe Contreras Date: Wed, 22 May 2013 00:03:09 GMT Subject: Re: [PATCH] prompt: fix show upstream with svn and zsh Message-ID: In-Reply-To: <20130521233617.GG30969@goldbirke> On Tue, May 21, 2013 at 6:36 PM, SZEDER Gábor wrote: > On Tue, May 21, 2013 at 06:04:35PM -0500, Felipe Contreras wrote: >> On Tue, May 21, 2013 at 5:41 PM, SZEDER Gábor wrote: >> >> > On Tue, May 21, 2013 at 10:54:27PM +0200, Thomas Gummerer wrote: >> >> Currently the __git_ps1 git prompt gives the following error with a >> >> repository converted by git-svn, when used with zsh: >> >> >> >> __git_ps1_show_upstream:19: bad pattern: svn_remote[ >> >> >> >> This was introduced by 6d158cba (bash completion: Support "divergence >> >> from upstream" messages in __git_ps1), when the script was for bash >> >> only. Make it compatible with zsh. >> > >> > What is the actual cause of this problem/incompatibility and how/why do >> > these changes fix it? >> >> I think the commit message makes that very clear. > > If that were the case I wouldn't have asked in the first place. You are not the authority on what *I think*, or if you meant s/If that were the case/If the message was clear/, still; you are not the authority on what is or is not true. Only on what is your opinion. -- Felipe Contreras