From: Felipe Contreras Date: Wed, 12 Jun 2013 20:11:59 GMT Subject: Re: [PATCH 0/3] Refactor useful notes functions into notes-utils.[ch] Message-ID: In-Reply-To: <7vzjuv14ir.fsf@alter.siamese.dyndns.org> On Wed, Jun 12, 2013 at 3:02 PM, Junio C Hamano wrote: >> ... Alas, this >> simple solution reject on the basis that we shouldn't organize the >> code, because the code is not meant to be organized. > > The proposed patch was rejected on the basis that it was organized > the code in a wrong way. And your patch shows how it should be > done. In your opinion. The fact that nobody outside of 'git' will ever use init_copy_notes_for_rewrite() still remains. Therefore this "organization" is wrong. -- Felipe Contreras