From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 16 Mar 2023 23:21:08 GMT
Subject: Re: [PATCH try2] completion: prompt: use generic colors
Message-ID: <CAMP44s3eVcfaeQC-BB+F4FE1e7m=fFj6F3pSP-qrb9uPX9zT1A@mail.gmail.com>
In-Reply-To: <xmqq5yb0i9nz.fsf@gitster.g>

On Thu, Mar 16, 2023 at 5:00 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Joakim Petersen <joak-pet@online.no> writes:
>
> > I've played around a bit with this patch, and it seems to work as
> > advertised.
>
> As the change itself is so trivial and likely to exhibit problem
> immediatly if it were not right (e.g. for some version of the shell
> but not for others), let's queue it.

For the record, it's not even the shell, it's the readline library,
and those markers are present since the initial import in 2011:

https://git.savannah.gnu.org/cgit/readline.git/tree/readline.h?id=06cd36cdc90634c88636a6d09230c573078ead0e#n282

#define RL_PROMPT_START_IGNORE '\001'
#define RL_PROMPT_END_IGNORE '\002'

-- 
Felipe Contreras