From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 09 Jun 2013 18:19:03 GMT
Subject: Re: [PATCH v4 09/45] sequencer: remove useless indentation
Message-ID: <CAMP44s3VL-uDPcsUyaYX3ESFbdj7h0XGuVZD+y8J_KewHcPC5g@mail.gmail.com>
In-Reply-To: <20130609181724.GA11516@paksenarrion.iveqy.com>

On Sun, Jun 9, 2013 at 1:17 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:
> On Sun, Jun 09, 2013 at 11:40:21AM -0500, Felipe Contreras wrote:
>> By using good ol' goto.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> I don't see this as an indentation change but as a restructing of the
> code. I would prefer something more like
> "Replace early return with goto cleanup" (but better phrased).

The explains what the patch is doing, but not why. Why is more important.

> The same goes for the next patch in this serie, I would prefer if the
> shortlog tells what have been done, not how hard it was to do.

It explains what it is, and why it makes sense.

-- 
Felipe Contreras