From: Felipe Contreras Date: Tue, 11 Jun 2013 17:26:42 GMT Subject: Re: [PATCH v4 31/45] rebase: trivial cleanup Message-ID: In-Reply-To: <20130611172416.GB20009@paksenarrion.iveqy.com> On Tue, Jun 11, 2013 at 12:24 PM, Fredrik Gustafsson wrote: > On Tue, Jun 11, 2013 at 12:09:32PM -0500, Felipe Contreras wrote: >> It's not removed. It's simply moved. > > Sorry about that, I wasn't paying enough attention. But why are you > moving it? > > All other arguments to git am is set in git-rebase.sh, why just set > -q just before the invokation in git-rebase--am.sh? Because the next patch checks if there's any arguments meant for 'git am' to switch to am rebase mode. We shouldn't switch to that mode if the only argument to 'git am' is going to be -q. -- Felipe Contreras