From: Felipe Contreras Date: Wed, 12 Jun 2013 18:28:05 GMT Subject: Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c Message-ID: In-Reply-To: On Wed, Jun 12, 2013 at 2:10 AM, Johan Herland wrote: > On Wed, Jun 12, 2013 at 2:32 AM, Felipe Contreras > wrote: >> On Tue, Jun 11, 2013 at 7:13 PM, Johan Herland wrote: >>> This is a pure code movement of the machinery for copying notes to >>> rewritten objects. This code was located in builtin/notes.c for >>> historical reasons. In order to make it available to builtin/commit.c >>> it was declared in builtin.h. This was more of an accident of history >>> than a concious design, and we now want to make this machinery more >>> widely available. >>> >>> Hence, this patch moves the code into the new notes-utils.[hc] files >>> which are included into libgit.a. Except for adjusting #includes >>> accordingly, this patch merely moves the relevant functions verbatim >>> into the new files. >>> >>> Cc: Thomas Rast >>> Signed-off-by: Johan Herland >> >> I wonder where you got that idea from. Did you come up with that out thin air? > > Obviously not. I should add > > Suggested-by: Junio C Hamano You are still not explaining where the idea came from. And you are doing that with the express purpose of annoying. Where did the idea come from? -- Felipe Contreras