From: Felipe Contreras Date: Tue, 17 Jan 2012 23:04:12 GMT Subject: Re: [PATCH] bash-completion: don't add quoted space for ZSH (fix regression) Message-ID: In-Reply-To: <7vzkdmqebh.fsf@alter.siamese.dyndns.org> On Tue, Jan 17, 2012 at 10:11 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Tue, Jan 17, 2012 at 9:18 PM, Felipe Contreras >> wrote: >>> On Sat, Jan 14, 2012 at 8:55 PM, Matthieu Moy wrote: >>>> Commit a31e626 (completion: optimize refs completion) introduced a >>>> regression for ZSH users: ref names were completed with a quoted trailing >>>> space (i.e. "git checkout ma" completes to "git checkout master\ "). The >>>> space is convenient for bash users since we use "-o nospace", but a >>>> quoted space is worse than nothing. The absence of trailing space for ZSH >>>> is a long-standing issue, that this patch is not fixing. We just fix the >>>> regression by not appending a space when the shell is ZSH. >>> >>> I have this issue with the script from v1.7.8.3, and I think it >>> started with a zsh update. >> >> Yeah, works fine with zsh 4.3.11, not 4.3.14 or 15. > > As I was planning to queue Matthieu's patch as-is as a regression fix > before v1.7.9-rc2, I would appreciate if you can clarify this report a > bit. Do you mean with the patch more recent versions of zsh still does not > like the workaround and adds quoted space at the end? I am saying I am seeing the issue (or at least the same symptom) even before a31e626 with recent zsh versions. I will try a patched version of the script and a31e626, but I'm guessing the result would be the same. -- Felipe Contreras