From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 18 Nov 2012 08:48:01 GMT
Subject: Re: [PATCH 2/7] completion: fix args of run_completion() test helper
Message-ID: <CAMP44s3FmB3F5zjQcVQJDwo7K5m19203Z7D67beHv726g3TL_A@mail.gmail.com>
In-Reply-To: <1353150353-29874-3-git-send-email-szeder@ira.uka.de>

On Sat, Nov 17, 2012 at 12:05 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:

>  test_expect_success 'basic' '
> -       run_completion "git \"\"" &&
> +       run_completion git "" &&

I don't like this approach. I prefer

run_completion "git "

So that it's similar to how test_completion is called:

run_completion "git f"
test_completion "git f"

-- 
Felipe Contreras