From: Felipe Contreras Date: Wed, 17 Apr 2013 22:30:33 GMT Subject: Re: [PATCH] gitremote-helpers(1): clarify refspec behaviour Message-ID: In-Reply-To: <505914600ac7f4afc26f8b29fbece26156c87519.1365272021.git.john@keeping.me.uk> On Sat, Apr 6, 2013 at 12:13 PM, John Keeping wrote: > --- a/Documentation/gitremote-helpers.txt > +++ b/Documentation/gitremote-helpers.txt > @@ -174,8 +174,8 @@ ref. > This capability can be advertised multiple times. The first > applicable refspec takes precedence. The left-hand of refspecs > advertised with this capability must cover all refs reported by > -the list command. If no 'refspec' capability is advertised, > -there is an implied `refspec *:*`. > +the list command. If a helper does not need a specific 'refspec' > +capability then it should advertise `refspec *:*`. But if it advertises a straight 'refspec *:*', nothing would work. If anything, it should be 'refs/heads/*:refs/remotes/$alias/*', but then tags would fail. Why not just tell the remote helpers to do the right thing and avoid this comment altogether? -- Felipe Contreras