From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 31 Oct 2013 19:33:34 GMT
Subject: Re: [PATCH 06/16] shortlog: add missing declaration
Message-ID: <CAMP44s2zTFKeHxp0G1imLXdHfzao_DSY+mkm7awYedwYafFZ+w@mail.gmail.com>
In-Reply-To: <xmqqk3gt5kht.fsf@gitster.dls.corp.google.com>

On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Otherwise we would have to include commit.h.
>
> Was there a reason why commit.h is not included here, just like
> revision.h would include diff.h, so that users of shortlog.h do not
> have to worry about including commit.h themselves?

Because you can't do:

struct diff_options;
struct diff_options diffopt;

The storage size is not known, but you can do:

struct diff_options;
struct diff_options *diffopt;

-- 
Felipe Contreras