From: Felipe Contreras Date: Fri, 17 May 2013 06:09:57 GMT Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups Message-ID: In-Reply-To: On Fri, May 17, 2013 at 1:04 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> This is what Linux's checkpatch throws: > > Perhaps it's time to include checkpatch.pl in our tree and update our > CodingGuidelines? checkpatch only works with a Linux tree, and it doesn't treat this alignment as an error, not even a warning, because Linux's style doesn't have it specified either. In Linux, maintainers couldn't possibly reject a patch because of this. -- Felipe Contreras