From: Felipe Contreras Date: Tue, 14 Feb 2012 20:28:14 GMT Subject: Re: [PATCH 2/2] t: mailmap: add simple name translation test Message-ID: In-Reply-To: <7v8vk56us3.fsf@alter.siamese.dyndns.org> On Tue, Feb 14, 2012 at 10:10 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- > > It was clear that we didn't have any test for "blame -e" hence it was no > brainer to judge that the patch 1/2 is good without any description. > > But I am scratching my head, deciphering what this patch adds. > > It appears to me that the existing tests that map author@example.com from > the original "A U Thor" to "Repo Guy" and inspect names and mails in > various output already cover this "Wrong with can be > corrected to Mr. Right" case this patch adds. Yes, but in the first tests they don't check for 'git blame', and much less 'git blame -e', and the second tests only check complex mappings. > What am I missing?  Instead of explaining it to me, can it be explained in > the log message? If an explanations along the lines of the above make sense, I can resend. Cheers. -- Felipe Contreras