From: Felipe Contreras Date: Fri, 02 Nov 2012 15:34:38 GMT Subject: Re: [PATCH v3 4/4] fast-export: make sure refs are updated properly Message-ID: In-Reply-To: <20121102131255.GB2598@sigill.intra.peff.net> On Fri, Nov 2, 2012 at 2:12 PM, Jeff King wrote: > On Tue, Oct 30, 2012 at 05:37:21PM -0700, Jonathan Nieder wrote: > >> If the commit does not have the SHOWN or UNINTERESTING flag set but it >> is going to get the UNINTERESTING flag set during the walk because of >> a negative commit listed on the command line, this patch won't help. > > Right, so my understanding of the situation is that doing this: > > $ git branch foo master~1 > $ git fast-export foo master~1..master > > won't show "foo", which seems wrong to me. _But_ we currently get that > wrong already, so Felipe's patches are not making anything worse, but > are fixing some situations (namely when master~1 is not mentioned on the > command-line, but rather in a marks file). > > Is that correct? Yes, that's correct. But my patch ("make sure refs are updated properly") does _not_ change in any shape or form what happens with what you specify in the command line, only what happens with marks. Cheers. -- Felipe Contreras