From: Felipe Contreras Date: Tue, 13 May 2014 13:18:26 GMT Subject: Re: [PATCH 2/2] wincred: avoid overwriting configured variables Message-ID: In-Reply-To: On Tue, May 13, 2014 at 1:34 AM, Erik Faye-Lund wrote: > On Tue, May 13, 2014 at 8:01 AM, Stepan Kasal wrote: >> From: Pat Thoyts >> Date: Wed, 24 Oct 2012 00:15:29 +0100 >> >> Signed-off-by: Pat Thoyts >> Signed-off-by: Stepan Kasal >> --- >> contrib/credential/wincred/Makefile | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile >> index 39fa5e0..e64cd9a 100644 >> --- a/contrib/credential/wincred/Makefile >> +++ b/contrib/credential/wincred/Makefile >> @@ -1,9 +1,5 @@ >> all: git-credential-wincred.exe >> >> -CC = gcc >> -RM = rm -f >> -CFLAGS = -O2 -Wall >> - > > Would it be better to set these if not already set, i.e: > > -CC = gcc > -RM = rm -f > -CFLAGS = -O2 -Wall > +CC ?= gcc > +RM ?= rm -f > +CFLAGS ?= -O2 -Wall > > instead? Set by whom? If it's by the environment you should be running 'make -e'. -- Felipe Contreras -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.