From: Felipe Contreras Date: Sat, 04 Feb 2012 21:59:04 GMT Subject: Re: [PATCH 2/3] t: mailmap: add 'git blame -e' tests Message-ID: In-Reply-To: <20120204211351.GB3278@burratino> On Sat, Feb 4, 2012 at 11:13 PM, Jonathan Nieder wrote: > Felipe Contreras wrote: >> On Sat, Feb 4, 2012 at 10:10 PM, Jonathan Nieder wrote: > >>> Since I didn't receive a copy of the cover letter or patch 1, I don't >>> know what this is intended to test _for_.  Good --- I can more easily >>> convey the reaction of future readers who do not necessarily know the >>> context in which the patch was written (and the commit message does >>> not seem to say). > [...] >> Look at the title: >> add 'git blame -e' tests >> >> s/blame/blame -e/ > > And?  After copy/pasting this particular test with that substitution, > what do we get a test for? For 'git blame -e'. > What class of problem is it supposed to catch? Problems related to 'git blame -e'? > By the way, "I blindly copy/pasted" does not seem like a very sensible > excuse for writing meaningless code (such as the "# git blame" comment > line).  Before the code contained one riddle.  Afterwards it has two. Fine, the drop the patch then... Who needs to test 'git blame -e' anyway, the current situation of having zero tests for it is perfectly fine. Or just apply it. Don't let the perfect be the enemy of the good. Cheers. -- Felipe Contreras