From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 08 Sep 2013 23:18:14 GMT
Subject: Re: [PATCH 0/4] Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions
Message-ID: <CAMP44s2cXnrR2WHtyFKgNxi7AtuS9dA9if1rqFaH2b_35YTfiw@mail.gmail.com>
In-Reply-To: <xmqqvc2b5fkg.fsf@gitster.dls.corp.google.com>

On Sun, Sep 8, 2013 at 1:33 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:

> Calling the abstraction "test_diff" might have avoided the wasted
> brain bandwidth in this thread, but I do not think renaming it in
> test-lib-functions.sh is worth the trouble, either ;-)

Yes, but then it wouldn't be clear what's the main purpose of
test_diff(). Primarily what we want is to check that they are the
same. The diff is secondary, and it's not actually *needed*.

-- 
Felipe Contreras