From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Wed, 28 Aug 2013 20:48:34 GMT
Subject: Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors
Message-ID: <CAMP44s2bu9gUE=McYq1prhjC3O2CRj1W_Yc+-CjTkk6Gc3JFTw@mail.gmail.com>
In-Reply-To: <vpqhae97f8j.fsf@anie.imag.fr>

On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> +     echo greg >> content &&
>> +     git add content &&
>> +     git commit -m one
>
> test_commit would make it shorter.

And it would make it inconsistent with the rest of the script.

>> +     bzr log | grep "^committer: " > ../actual
>> +     ) &&
>> +
>> +     echo "committer: Grégoire <committer@example.com>" > expected &&
>
> Git's source code usually says >../actual and >expected, without space
> after '>'.

Not that usually:

% git grep ' > ' t/*.sh | wc -l
1943

-- 
Felipe Contreras