From: Felipe Contreras Date: Tue, 04 Jun 2013 17:40:14 GMT Subject: Re: [PATCH v2 3/8] cherry-pick: add --skip-empty option Message-ID: In-Reply-To: <7vbo7l93t6.fsf@alter.siamese.dyndns.org> On Tue, Jun 4, 2013 at 12:35 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >>> I think just "Skip commits that are or become empty" without saying >>> "Instead of failing," is fine, too. >> >> I think "Instead of failing" makes perfect sense, because it's not our >> job to describe what other options do,... >> ... >> simply explain what this option >> do. > > Which means "Skip commits" and nothing else. Saying "Instead of > failing" explains what would happen if you ran the command without > any option, Which *BY FAR* the most widely use-case of cherry-pick. What? 99% of the time? > which is entirely irrelevant, It's totally and completely relevant. It couldn't be more relevant. > We share the same "the --skip-empty option does not have anything to > do with the --allow-empty option, and we do not have to say anything > about what happens when the command is run with that unrelated > option". You didn't answer, what happens when you run --skip-empty and --allow-empty? -- Felipe Contreras