From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 07 Apr 2013 16:03:15 GMT
Subject: Re: [PATCH v3 4/4] format-patch: add format.cover-letter configuration
Message-ID: <CAMP44s2TvC9Ek51GyhPqtv7b-w8u8kr=tQsmdWEVGOycb6MEqA@mail.gmail.com>
In-Reply-To: <vpqwqsefl9b.fsf@grenoble-inp.fr>

On Sun, Apr 7, 2013 at 9:50 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> So, I'm a user that does 'git format-patch --cover-letter=auto origin'
>> so I don't have the format.coverletter=auto configuration. Why? Why am
>> I not setting that configuration, and why am I running
>> --cover-letter=auto?
>
> The command may well be ran from a script or alias.

Wouldn't this work for both cases?

% git -c format.coverletter=auto format-patch

> It is good in
> general to give the user/script writer a simple way to get predictible
> behavior regardless of the configuration.

Predictable means when the user does X, (s)he would know what would be
the outcome. But if the user never does X, it doesn't matter.

-- 
Felipe Contreras