From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Wed, 08 May 2013 06:49:54 GMT
Subject: Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()
Message-ID: <CAMP44s2S53kUvp3LcYcXdzq=bwP-kG0uZmG+s-u_6mEEjABEBA@mail.gmail.com>
In-Reply-To: <7v8v3qgglz.fsf@alter.siamese.dyndns.org>

On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> In some circumstances 'git log' might fail, but not because the @
>> parsing failed. For example: 'git rev-parse' might succeed and return a
>> bad object, and then 'git log' would fail.
>>
>> The layer we want to test is revision parsing, so let's test that
>> directly.
>
> Hmph, but
>
>         git rev-parse Makefile
>
> would happily succeed if there happens to be Makefile in the
> directory.
>
> Are we expecting that they are always object names?  If that is the
> case, perhaps
>
>         git rev-parse --verify "$1"
>
> would express the intention better.

Probably, although the same would fail before this patch.

-- 
Felipe Contreras