From: Felipe Contreras Date: Tue, 30 Oct 2012 21:35:51 GMT Subject: Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly Message-ID: In-Reply-To: On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier wrote: > On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras > wrote: >> Why would it? We are not changing the way objects are exported, the >> only difference is what happens at the end >> (handle_tags_and_duplicates()). > > Because the marking is per-commit, not per-ref, right? Oh, you meant using marks? It doesn't matter anyway, because get_tags_and_duplicates() would get 'one' on the first run, and 'two' on the second. If you meant something like this: % git fast-export $marks_args one % git fast-export $marks_args one two Then yeah, 'one' will be updated once again in the second command, but there's nothing fatal about it, and your patch series had the same result. > Perhaps you > could add a simple test case to make sure it works as expected? > Something along the lines of the scenario I described in my previous > email? I'm not sure what that test should be doing. Cheers. -- Felipe Contreras