From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 18 Nov 2012 09:38:08 GMT
Subject: Re: [PATCH 1/7] completion: make the 'basic' test more tester-friendly
Message-ID: <CAMP44s2JgNcKMmhohdg1Ynz1C6r+HVCLm8XCqs=hhjE2_8vs-A@mail.gmail.com>
In-Reply-To: <20121117230022.GA3815@elie.Belkin>

On Sun, Nov 18, 2012 at 12:00 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> SZEDER Gábor wrote:
>
>> The 'basic' test uses 'grep -q' to filter the resulting possible
>> completion words while looking for the presence or absence of certain
>> git commands, and relies on grep's exit status to indicate a failure.
> [...]
>> To make testers' life easier provide some output about the failed
>> condition: store the results of the filtering in a file and compare
>> its contents to the expected results by the good old test_cmp helper.
>
> Looks good.  I wonder if this points to the need for a test_grep
> helper more generally.

It does.

-- 
Felipe Contreras