From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Wed, 28 Aug 2013 21:21:02 GMT
Subject: Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors
Message-ID: <CAMP44s2G0Nm56q30EXgjpatsJhQZgiJ6uxr83o_74TsUAnHt3w@mail.gmail.com>
In-Reply-To: <CALWbr2xi1+EKHry4GRwLv=SwRUsaTKLQc6RUfuPKEre4pcpaFg@mail.gmail.com>

On Wed, Aug 28, 2013 at 3:54 PM, Antoine Pelisse <apelisse@gmail.com> wrote:
> On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> +     echo greg >> content &&
>>>> +     git add content &&
>>>> +     git commit -m one
>>>
>>> test_commit would make it shorter.
>>
>> And it would make it inconsistent with the rest of the script.
>>
>>>> +     bzr log | grep "^committer: " > ../actual
>>>> +     ) &&
>>>> +
>>>> +     echo "committer: Grégoire <committer@example.com>" > expected &&
>>>
>>> Git's source code usually says >../actual and >expected, without space
>>> after '>'.
>>
>> Not that usually:
>>
>> % git grep ' > ' t/*.sh | wc -l
>> 1943
>
> There are many false positive in that count.
>
> As in this one:
> $ git grep ' >[^ ]' -- t/*.sh | wc -l
> 10354

Ten thousand is still a lot, and the claim remains: it's far from
unusual to follow this style.

-- 
Felipe Contreras