From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 13 Oct 2013 10:15:42 GMT
Subject: Re: [PATCH try2 7/8] push: add --set-publish option
Message-ID: <CAMP44s2FihCyAJKLYqMzQSPOz7FgR_hh7EMwmS-socR0Zn8O_w@mail.gmail.com>
In-Reply-To: <CAPig+cQ=RkFWssANKQ=mca1jD6MGQuPxAV-SyM8rfHMLYoDHfA@mail.gmail.com>

On Sun, Oct 13, 2013 at 5:03 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Oct 12, 2013 at 3:05 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> diff --git a/t/t5529-push-publish.sh b/t/t5529-push-publish.sh
>> new file mode 100755
>> index 0000000..2037026
>> --- /dev/null
>> +++ b/t/t5529-push-publish.sh
>> @@ -0,0 +1,70 @@
>> +#!/bin/sh
>> +
>> +test_description='push with --set-publish'
>> +
>> +. ./test-lib.sh
>> +
>> +test_expect_success 'setup bare parent' '
>> +       git init --bare parent &&
>> +       git remote add publish parent
>> +'
>> +
>> +test_expect_success 'setup local commit' '
>> +       echo content >file &&
>> +       git add file &&
>> +       git commit -m one
>> +'
>> +
>> +check_config() {
>> +       (echo $2; echo $3) >expect.$1
>> +       (git config branch.$1.pushremote
>> +        git config branch.$1.push) >actual.$1
>> +       test_cmp expect.$1 actual.$1
>> +}
>
> Do you want to maintain &&-chain in this test?

As much as we want to do it in t/t5523-push-upstream.sh, which has
this exact function.

-- 
Felipe Contreras