From: Felipe Contreras Date: Thu, 28 Jul 2011 15:00:48 GMT Subject: Re: Git commit generation numbers Message-ID: In-Reply-To: On Fri, Jul 22, 2011 at 10:06 PM, Linus Torvalds wrote: > On Fri, Jul 22, 2011 at 11:34 AM, Jakub Narebski wrote: >> >> That is IF unknown headers are copied verbatim during rebase.  For >> "encoding" header this is a good thing, for "generation" it isn't. > > Afaik, they aren't copied verbatim, and never have been. Afaik, the > only thing that has *ever* written commits is "commit_tree()" > (originally "main()" in commit-tree.c). Why is this red herring even > being discussed? > > Of course you can always generate bogus commits by writing them by > hand. But that's irrelevant. Let's suppose for a moment that the commits do have these wrong generation numbers, shouldn't a fetch on the newer client check these and show an error? But what if they are pushed to a central server that has old version of git? It would be messy. -- Felipe Contreras