From: Felipe Contreras Date: Wed, 23 May 2012 11:59:10 GMT Subject: Re: [PATCH 2/2] completion: split __git_ps1 into a separate script Message-ID: In-Reply-To: <4FBC0019.6030702@in.waw.pl> On Tue, May 22, 2012 at 11:07 PM, Zbigniew Jędrzejewski-Szmek wrote: > On 05/22/2012 10:46 PM, Felipe Contreras wrote: >>  contrib/completion/git-completion.bash |  257 +--------------------------- >>  contrib/completion/git-prompt.sh       |  287 ++++++++++++++++++++++++++++++++ >>  t/t9903-bash-prompt.sh                 |    2 +- >>  3 files changed, 290 insertions(+), 256 deletions(-) >>  create mode 100644 contrib/completion/git-prompt.sh > since git-prompt is not completion related anymore, should a different > directory be used? That's a good point. I personally wouldn't worry too much about this until there's a real issue. If we were to fix this, I would rather have a 'shell' sub-directory and move everything there; I think have a sub-directory for 'completion' and another for 'prompt' would be overkill. Unfortunately this would mean packagers need to update. Cheers. -- Felipe Contreras