From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 18 Nov 2012 08:34:19 GMT
Subject: Re: [PATCH 4/7] completion: add tests for invalid variable name among completion words
Message-ID: <CAMP44s26MkA8QWm_JQkk8M0mM39XK0Fv1CBZfpt52VKt1urkAw@mail.gmail.com>
In-Reply-To: <20121117234059.GD3815@elie.Belkin>

On Sun, Nov 18, 2012 at 12:40 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> SZEDER Gábor wrote:
>
>>                                                      The breakage can
>> be simply bogus possible completion words, but it can also be a
>> failure:
>>
>>   $ git branch '${foo.bar}'
>>   $ git checkout <TAB>
>>   bash: ${foo.bar}: bad substitution
>
> Or arbitrary code execution:
>
>         $ git branch '$(>kilroy-was-here)'
>         $ git checkout <TAB>
>         $ ls -l kilroy-was-here
>         -rw-rw-r-- 1 jrn jrn 0 nov 17 15:40 kilroy-was-here
>
> The final version of this patch should go to maint.  Thanks for
> catching it.

Shouldn't this go to the commit message?

-- 
Felipe Contreras