From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 01 Sep 2013 11:20:18 GMT
Subject: Re: [PATCH 2/6] Add concept of 'publish' branch
Message-ID: <CAMP44s1x=7k3XTPSzHFk4gtJBY301mVbsQWammsp3HpdSzp2CA@mail.gmail.com>
In-Reply-To: <CAPig+cQUiSC4r01nSqRnrDj230x=tUK4dGUXhWrUitSAVKZ-Wg@mail.gmail.com>

On Sun, Sep 1, 2013 at 3:41 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sun, Sep 1, 2013 at 4:26 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:

>> +static void setup_push_simple(struct remote *remote, struct branch *branch,
>> +                               int triangular)
>> +{
>> +       if (branch->push_name) {
>> +               struct strbuf refspec = STRBUF_INIT;
>> +               strbuf_addf(&refspec, "%s:%s", branch->name, branch->push_name);
>> +               add_refspec(refspec.buf);
>
> strbuf_release(&refspec);

Actually no, wee need that buffer. See setup_push_upstream().

-- 
Felipe Contreras