From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sat, 08 Jun 2013 17:27:55 GMT
Subject: Re: [PATCH v3 2/2] read-cache: plug a few leaks
Message-ID: <CAMP44s1ffOUd3DkphHAj8ZmovBazPFdMgtvEptR6kW9+ZMLLjA@mail.gmail.com>
In-Reply-To: <51B36849.3030608@lsrfire.ath.cx>

On Sat, Jun 8, 2013 at 12:22 PM, René Scharfe
<rene.scharfe@lsrfire.ath.cx> wrote:

> Let's find and fix those leaks by freeing memory in the right places.
> Freeing memory just in case in places where we can show that no leak is
> triggered by our test suite doesn't help.

It helps; it prevents leaks. The real culprit is the bogus API, but I
don't see that changing anytime soon, so there are two options when
somebody makes a mistake the API allows; leak or don't leak. And you
seem to prefer the leak, even though it provides absolutely no
advantage.

-- 
Felipe Contreras