From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 06 Apr 2012 19:42:16 GMT
Subject: Re: [PATCH RESEND] send-email: add 'specify-author' option
Message-ID: <CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com>
In-Reply-To: <7vobr4236g.fsf@alter.siamese.dyndns.org>

On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so
>> while applying the patches, the author has to be fixed manually.
>>
>> This option allows to always specify the author of the commit in the
>> body of the message, even if the committer is the author.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>
> I wouldn't say that the existing option names to send-email are great, but
> I have to say that the one added by this is simply horrible ;-)
>
> The first paragraph of the proposed commit log message states the problem
> it tries to address very clearly, which is good, but is "From: " the only
> thing that needs this?  I am wondering if this should be named and behave
> more like "--duplicate-header" or "--in-body-header".

I have never seen any other 'in-body-header' other than From, and I
don't see how that would be useful. Anybody else?

-- 
Felipe Contreras