From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sat, 22 Jun 2019 15:03:22 GMT
Subject: Re: [PATCH 01/14] completion: zsh: fix __gitcomp_direct()
Message-ID: <CAMP44s1ZZu97tbPS6xGi6=i3r-+bA2E=Ug5BeXmzKH9=dWqE8w@mail.gmail.com>
In-Reply-To: <20190621223107.8022-2-felipe.contreras@gmail.com>

On Fri, Jun 21, 2019 at 5:31 PM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
> Many callers append a space suffix, but zsh automatically appends a
> space, making the completion add two spaces, for example:

> --- a/contrib/completion/git-completion.zsh
> +++ b/contrib/completion/git-completion.zsh
> @@ -73,7 +73,7 @@ __gitcomp_direct ()
>
>         local IFS=$'\n'
>         compset -P '*[=:]'
> -       compadd -Q -- ${=1} && _ret=0
> +       compadd -Q -- ${${=1}% } && _ret=0

This is better actually:

compadd -Q -S '' -- ${=1} && _ret=0

-- 
Felipe Contreras