From: Felipe Contreras Date: Mon, 16 Apr 2012 21:09:05 GMT Subject: Re: [PATCH v2] completion: add new git_complete helper Message-ID: In-Reply-To: <7v7gxftn78.fsf@alter.siamese.dyndns.org> On Mon, Apr 16, 2012 at 11:51 PM, Junio C Hamano wrote: > Earlier I said "Ok" to you based on that assumption; somebody may have his > own git_complete that rebuilds a test integration branch (i.e. completes > it) and having the name git_complete exported by us will indirectly affect > her fingers if she installs bash_completion and Git package on her system. She might have had the same problem if she named it _git_complete. That might be unlinkely, but I also find it unlikely that anybody would have a git_complete function. In fact, I find it unlikely that people would write shell functions like that; it's much easier to write scripts and put them in $PATH. Even more, I just added a foobar() function in my profile, and I also added a foobar() function in /etc/bash_completion.d/git. I don't see my function replaced in any way, even after typing and completing 'git' commands. I don't know how that's possible, but that's why I don't like to take these types of claims as face value. Cheers. -- Felipe Contreras