From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 07 Dec 2020 03:26:09 GMT
Subject: Re: [PATCH v2 3/5] gitweb/Makefile: conditionally include ../GIT-VERSION-FILE
Message-ID: <CAMP44s1TQ3vmn2LT40jXA_3503hLWvadc3oDsatrOZ9weO_t3w@mail.gmail.com>
In-Reply-To: <f96f5cf3-713f-5c89-d486-e1a3f1c97b07@ramsayjones.plus.com>

On Sun, Dec 6, 2020 at 6:37 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

> Notice that the 'clean' target is making a nested call to the parent
> Makefile to ensure that the GIT-VERSION-FILE is up-to-date. This is to
> ensure that the $(GIT_VERSION) make variable is set, once that file had
> been included. However, the 'clean' target does not use the $(GIT_VERSION)
> variable, so this is wasted effort.

Same goes here.

-- 
Felipe Contreras