From: Felipe Contreras Date: Mon, 29 Oct 2012 22:02:31 GMT Subject: Re: [PATCH v4 00/13] New remote-hg helper Message-ID: In-Reply-To: <20121029215631.GF20513@sigill.intra.peff.net> On Mon, Oct 29, 2012 at 10:56 PM, Jeff King wrote: > On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: > >> >> Yeah, the test script is not ready for merging, it needs to check for >> >> python, hg, and hg-git. >> >> >> >> Do you have hg-git installed? >> > >> > No. But it's important that it fail gracefully; I can't even take it in >> > pu if I can't run the test suite in a sane way. >> >> The contrib part is fine for 'pu'. The tests aren't even meant to >> exercise stuff in 'contrib', right? There might be some exceptions, >> but either way, there's plenty of stuff in 'contrib' without any >> tests. The tests I'm providing are simply a little sugar. > > Yeah, contrib is a bit of a wildcard. Most things do not have tests. > Completion tests run as part of the main test suite (which to me means > that completion should arguably be promoted out of contrib). I agree, I didn't think of that when I wrote the completion tests, but now it seems appropriate, specially since there's discussion about moving the prompt out of contrib. > If remote-hg is going to live in contrib, it probably makes sense to > have its tests live there, too, like subtree. Probably, I'll check that option. But eventually I think it should be installed by default, unless somebody can come up for a reason not to. For now contrib might be OK. > It means less test > exposure, but the robustness of the tests does not have to be as high. > You could also have no tests, but since you have them, it seems silly > not to include them. People know that items in contrib/ may not be as > mature as the rest of git. Yeah, it's only a matter of figuring out how to run them. Cheers. -- Felipe Contreras