From: Felipe Contreras Date: Sat, 06 Apr 2013 16:32:10 GMT Subject: Re: [PATCH] remote-helpers: remove --graph in hg_log() Message-ID: In-Reply-To: On Sat, Apr 6, 2013 at 10:12 AM, Antoine Pelisse wrote: > On Sat, Apr 6, 2013 at 6:06 PM, Felipe Contreras > wrote: >> On Sat, Apr 6, 2013 at 10:00 AM, Antoine Pelisse wrote: >>> I'm not so confident that --graph is useless to the test. If it's really >>> necessary, it would be nice either to activate it in setup() or to use >>> it just for the command through: "--config extensions.graphlog=". >> >> I think it should be activated in the setup, it comes packaged with >> mercurial, and it's likely that many users have it enabled. > > But is it relevant to the tests ? I have the feeling that it's not > strictly necessary to both add an extension to hgrc and a command line > option. (and indeed, the tests still work for me, but maybe I'm > missing something). It's possible that the order of the commits make them look the same, but the topology is different. At least I saw a couple of cases when I was working on them, but of course, that was on test-hg-hg-git.sh, which should also have a patch. I think adding it in hgrc is the best option. -- Felipe Contreras