From: Felipe Contreras Date: Fri, 02 Nov 2012 16:41:34 GMT Subject: Re: [PATCH v4 00/13] New remote-hg helper Message-ID: In-Reply-To: <20121102144827.GB11170@sigill.intra.peff.net> On Fri, Nov 2, 2012 at 3:48 PM, Jeff King wrote: > On Thu, Nov 01, 2012 at 05:08:52AM +0100, Felipe Contreras wrote: > >> > Turns out msysgit's remote-hg is not exporting the whole repository, >> > that's why it's faster =/ >> >> It seems the reason is that it would only export to the point where >> the branch is checked out. After updating the to the tip I noticed >> there was a performance difference. >> >> I investigated and found two reasons: >> >> 1) msysgit's version doesn't export files twice, I've now implemented the same >> 2) msysgit's version uses a very simple algorithm to find out file changes >> >> This second point causes msysgit to miss some file changes. Using the >> same algorithm I get the same performance, but the output is not >> correct. > > Do you have a test case that demonstrates this? It would be helpful for > reviewers, but also helpful to msysgit people if they want to fix their > implementation. Cloning the mercurial repo: % hg log --stat -r 131 changeset: 131:c9d51742471c parent: 127:44538462d3c8 user: jake@edge2.net date: Sat May 21 11:35:26 2005 -0700 summary: moving hgweb to mercurial subdir hgweb.py | 377 ------------------------------------------------------------------------------------------ mercurial/hgweb.py | 377 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 377 insertions(+), 377 deletions(-) % git show --stat 1f9bcfe7cc3d7af7b4533895181acd316ce172d8 commit 1f9bcfe7cc3d7af7b4533895181acd316ce172d8 Author: jake@edge2.net Date: Sat May 21 11:35:26 2005 -0700 moving hgweb to mercurial subdir mercurial/hgweb.py | 377 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 377 insertions(+) Cheers. -- Felipe Contreras