From: Felipe Contreras Date: Mon, 09 Apr 2012 19:12:54 GMT Subject: Re: [PATCH 02/12] completion: simplify __gitcomp Message-ID: In-Reply-To: <4F83311B.50901@kdbg.org> On Mon, Apr 9, 2012 at 9:57 PM, Johannes Sixt wrote: > Am 08.04.2012 16:58, schrieb Felipe Contreras: >> On Sun, Apr 8, 2012 at 5:36 PM, Jonathan Nieder wrote: >>> (dropping Shawn from cc since I'm not under the impression he works >>>  on the completion script these days) >>> Felipe Contreras wrote: >>> >>>> Whoa! Breaking their tab completion? Where? Can you show me some evidence? >>> >>> If you weren't listening before, I'm not sure what I can add now[*]. >> >> This is what you said; "in exchange for us breaking their tab >> completion". There's a big difference between "breaking", and >> "*potentially* breaking". I have never seen any evidence of tab >> completion actually being broken. > > I have: > > http://thread.gmane.org/gmane.comp.version-control.msysgit/13310/focus=13335 > http://thread.gmane.org/gmane.comp.version-control.git/185184/focus=185189 I meant being broken by this patch. Plus this patch series actually fixes those issues. -- Felipe Contreras