From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 13 Apr 2012 23:43:00 GMT
Subject: Re: [PATCH v2 4/4] completion: improve 'git --exec-path' completion
Message-ID: <CAMP44s1C8HS2bo-dZOQKcFES8gt3=KK0h7c8uUJCeFX22ihLRg@mail.gmail.com>
In-Reply-To: <20120413233706.GD13995@burratino>

On Sat, Apr 14, 2012 at 2:37 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:
>
>> I don't understand, the commit message doesn't match what the patch
>> actually does.
>
> Try it, I guess?  At least for me,
>
>        git --exec-p<TAB>
>
> completes to
>
>        git --exec-path <cursor here>
>
> before the patch, and to
>
>        git --exec-path<cursor here>
>
> after the patch.  Which is different from your original patch.

Ah, it doesn't remove the current line, it just adds a new one. I'm
not sure how the completion results show up, but I guess it's better
than the alternatives.

-- 
Felipe Contreras