From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 16 May 2013 16:32:47 GMT
Subject: Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups
Message-ID: <CAMP44s17aD_ryeGWQazTcJ3nrhe6C9TLhKHhrUnys=Yj_ATa0A@mail.gmail.com>
In-Reply-To: <7vwqqy7v8g.fsf@alter.siamese.dyndns.org>

On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> I find it extremely annoying that an obviously correct patch is not
>> merged...
>
> A patch that receives "this breaks style" comments

*Invalid* "this breaks style" comments, because it doesn't break any
style mentioned in Documentation/CodingGuidelines.

If somebody dreamt about another style not mentioned in
Documentation/CodingGuidelines after drinking too much coffe, that's
irrelevant. The only relevant style is the defined style.

> and its author
> stubbornly refusing to fix what others pointed out, especially when
> the patch itself _is_ about style, cannot be "an obviously correct"
> patch, can it?

The patch makes the code follow Documentation/CodingGuidelines. Period.

-- 
Felipe Contreras