From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 02 Jun 2013 17:20:28 GMT
Subject: Re: [PATCH 4/6] completion: correct completion for format-patch
Message-ID: <CAMP44s16s3Uz6ybjYuqni9JdDX0XvG7F3z7F1cyNS2k=AqrkKQ@mail.gmail.com>
In-Reply-To: <1370181822-23450-5-git-send-email-artagnon@gmail.com>

On Sun, Jun 2, 2013 at 9:03 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> Currently, the completion for 'git format-patch' uses
> __git_complete_revlist.  Although this is technically correct, and you
> can
>
>   $ git format-patch master contrib
>
> where master is a ref and contrib is a pathspec, just like in 'git log',
> the usage is unidiomatic and undocumented.  'git format-patch' is used
> without pathspec filtering most of the time, and it makes sense to
> provide sensible completions using __git_refs.

This breaks 'git format-patch master..<TAB>'.

Moreover, this is a perfectly fine usage of 'git format-patch':

% git format-patch --full-diff master..fc/remote/hg-next --
contrib/remote-helpers/git-remote-bzr

Plus, even even with your patch 'contrib' will be completed regardless
(by default completion), wouldn't it?

NAK.

-- 
Felipe Contreras