From: Felipe Contreras Date: Mon, 07 May 2012 20:53:40 GMT Subject: Re: [RFC/PATCH v4 1/6] completion: add new __git_complete helper Message-ID: In-Reply-To: <7vfwbb6czu.fsf@alter.siamese.dyndns.org> On Mon, May 7, 2012 at 8:51 PM, Junio C Hamano wrote: > Felipe Contreras writes: > > >> +# this is NOT a public function; use at your own risk >> +__git_complete () > > The comment is enough to scare away people who might use it and then come > back to complain when this changes its implementation detail, but saying > "This is not X" without saying "This does Y" does not help those who want > to contribute updates to git-completion script.  Is there a short and > sweet description of what this is for and/or what this does? No. And this patch is not meant to help those people; I don't even need this, it's not my itch, I just did it because other people complained. Those people would have to scratch their own itch if they want some description of __git_complete (), I only want to reorganize the code and already did more than my fair share. -- Felipe Contreras