From: Felipe Contreras Date: Sun, 05 Feb 2012 21:11:20 GMT Subject: Re: [bug] blame duplicates trailing ">" in mailmapped emails Message-ID: In-Reply-To: <20120204232015.GB1170@sigill.intra.peff.net> On Sun, Feb 5, 2012 at 1:20 AM, Jeff King wrote: > On Sat, Feb 04, 2012 at 09:30:42PM +0200, Felipe Contreras wrote: > >> > but it feels like the fix should go into map_user.  I tried a few things, >> > like "git log -1 --format=%aE", and couldn't find other code paths with >> > this problem. So presumably they are all feeding email addresses without >> > the closing ">" (so one option is to just say "map_user needs to get >> > NUL-terminated strings). >> >> Perhaps, but I though the idea was to make it efficient. I think the >> above fix should be ok. > > Because of the calling convention of map_user, the buffer with the input > must also be writable (since it holds the result). So there should be no > loss of efficiency to convert the ">" into a "\0" (and in fact, the > simplest fix is probably to just have map_user "tie off" any ">" it > detects). Yes, but then the caller (git blame) would need to _always_ do that conversion before (">" -> "\0"), and after ("\0" -> ">"), as opposed to now, that it does the conversion only when map_user succeeds (or checks if it has to do it). -- Felipe Contreras