From: Felipe Contreras Date: Mon, 16 Apr 2012 10:04:41 GMT Subject: Re: [PATCH] tests: add tests for the bash prompt functions in the completion script Message-ID: In-Reply-To: <20120416094938.GE2900@goldbirke> 2012/4/16 SZEDER Gábor : > Hi, > > On Sun, Apr 15, 2012 at 11:56:36PM +0300, Felipe Contreras wrote: >> On Sun, Apr 15, 2012 at 11:31 PM, SZEDER Gábor wrote: >> > The tests cover the discovery of the .git directory in the __gitdir() >> > function in different scenarios, and the prompt itself, i.e. branch >> > name, detached heads, operations (rebase, merge, cherry-pick, bisect), >> > and status indicators (dirty, stash, untracked files; but not the >> > upstream status). >> > >> > Signed-off-by: SZEDER Gábor >> > --- >> > >> > Goes on top of fc/completion-tests (b8574ba7). >> > >> >  t/t9902-completion.sh |  436 +++++++++++++++++++++++++++++++++++++++++++++++++ >> >  1 file changed, 436 insertions(+) >> >> Perhaps it would make sense to create another file for these, > > I thought about that briefly but decided against it to avoid > duplicating the bash-specific checks at the beginning, but I don't > care that much either way. > >> specially since there's the plan of splitting the prompt stuff to a >> separate file. > > Oh, I was not aware of such a plan.  What would be the benefits of > such a move, why is it necessary?  Where would you split it up?  In > particular, what would happen with __gitdir(), which is used in many > completion functions and in __git_ps1() as well? I guess __gitdir() would be duplicated, I don't think that has been discussed. http://thread.gmane.org/gmane.comp.version-control.git/194188 Basically splitting helps for systems that use bash-completion, and also helps for zsh users who don't want the bash completion, but still want __git_ps1(). I split the file myself for this reason. Cheers. -- Felipe Contreras