From: Felipe Contreras Date: Sat, 01 Jun 2013 14:20:41 GMT Subject: Re: [PATCH] run-command: simplify wait_or_whine Message-ID: In-Reply-To: On Sat, Jun 1, 2013 at 9:08 AM, Duy Nguyen wrote: > On Sat, Jun 1, 2013 at 9:06 PM, Felipe Contreras > wrote: >> On Sat, Jun 1, 2013 at 9:03 AM, Duy Nguyen wrote: >>> On Sat, Jun 1, 2013 at 8:51 PM, Felipe Contreras >>> wrote: >>>> Nobody is checking for specific error codes; it's the errno that's >>>> important. >>> >>> Have you just disregarded the in-code comment you just removed with >>> one statement? >> >> Who cares about the comment? As I said, nobody is checking for those codes. > > Apparently I do. Why do you care about code comments that have no relation to reality? >>> Did you check all its callers? >> >> Yes, that's why I said nobody is checking for those codes. > > Thanks. If would be a few mails less if you stated so in the original message. So why did you think I said that that nobody is checking for those codes? Anyway, apparently somebody added code that checks for the specific code since I wrote this patch: 1250857 launch_editor: propagate signals from editor to git To my knowledge this is the only place where the specific number us actually checked. -- Felipe Contreras