From: Felipe Contreras Date: Sat, 01 Jun 2013 21:41:36 GMT Subject: Re: [PATCH] t0005: test git exit code from signal death Message-ID: In-Reply-To: <20130601172441.GB19234@sigill.intra.peff.net> On Sat, Jun 1, 2013 at 12:24 PM, Jeff King wrote: > On Sat, Jun 01, 2013 at 10:01:49AM -0500, Felipe Contreras wrote: > >> Anyway, if you care so much about the current behavior, why isn't >> there any tests that check for this? >> >> My patch passes *all* the tests. > > The test suite has never been (and probably never will be) a complete > specification of git's behavior. Noticing that a desired behavior is not > in the test suite is an opportunity to improve its coverage, not argue > that a change which breaks the desired behavior must therefore be > acceptable. Nobody did such a thing. I asked a question, and it's good that you are answering by filling the missing test-case. -- Felipe Contreras