From: Felipe Contreras Date: Mon, 30 Jan 2012 10:35:31 GMT Subject: Re: [PATCH 1/3] completion: be nicer with zsh Message-ID: In-Reply-To: <7v8vkperli.fsf@alter.siamese.dyndns.org> On Mon, Jan 30, 2012 at 6:34 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Let's avoid it. This has the advantage that the code is now actually >> understandable (at least to me), while before it looked like voodoo. > > I am somewhat hesitant to accept a patch to shell scripts on the basis > that the patch author does not understand the existing constructs that > are standard parts of shell idioms. I have been writing shell scripts for years[1], and I have *never* had an encounter with ':'. vim's sh syntax doesn't seem to be prepared for it, and zsh's sh emulation has problems only when ':' is involved, so I still think ':' is quite obscure. Plus, I haven't seen ${foo:=bar} that often. In any case, there's no need for ad hominem arguments; there is a problem when using zsh, that's a fact. [1] https://www.ohloh.net/accounts/felipec/positions/total -- Felipe Contreras