From: Felipe Contreras Date: Thu, 25 Oct 2012 13:33:03 GMT Subject: Re: [PATCH 1/3] t9350: point out that refs are not updated correctly Message-ID: In-Reply-To: On Thu, Oct 25, 2012 at 9:50 AM, Sverre Rabbelier wrote: > On Thu, Oct 25, 2012 at 12:48 AM, Jonathan Nieder wrote: >> Sverre Rabbelier wrote: >> >>> I know there was a reason why using UNINTERESTING didn't work >>> (otherwise we could've used that to start with, instead of needing >>> Junio's whence solution). I think all refs ended up being marked as >>> UNINTERESTING or somesuch. >> >> True. Is it be possible to check UNINTERESTING in revs->cmdline >> before the walk? It is possible to check in revs->pending, but '^foo master' will mark them both as UNINTERESTING, and 'master..master' as well, which again, is what we actually want, because that's how it works in the rest of git. > That might work, maybe Dscho remembers why we did not go with that approach. Because you want 'master..master' to output something, but that's wrong; it's changing the semantics of commitishes, and you don't need that to solve this problem. -- Felipe Contreras